Skip to content

cw1-subkeys: Migration example#525

Merged
hashedone merged 1 commit intomainfrom
511-migration
Nov 4, 2021
Merged

cw1-subkeys: Migration example#525
hashedone merged 1 commit intomainfrom
511-migration

Conversation

@hashedone
Copy link
Copy Markdown
Contributor

@hashedone hashedone commented Nov 3, 2021

Closes #510
Closes #511

SettingExpiredAllowance(Expiration),

#[error("Semver parsing error: {0}")]
SemVer(String),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be moved to StdError if we decide this is common one.

Copy link
Copy Markdown
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example. Thanks

@hashedone hashedone merged commit b230ea8 into main Nov 4, 2021
@hashedone hashedone deleted the 511-migration branch November 4, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate example Semver parsing / comparison

3 participants