cw1-whitelist-ng: Slight messages parsing improvement#523
Merged
Conversation
hashedone
force-pushed
the
ng-parsing-improvement
branch
from
d9ed6ab to
a3f696e
Compare
ethanfrey
approved these changes
Nov 2, 2021
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Looks cheaper and cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed collecting errors to vector which might be significant cost on wasm, while it is completely not needed. This should also improve efficiency of generating error message, as its format is now well known (instead of iteration based) - but it is less important as it would happen only on err-path. And message itself might improve.