Conversation
ethanfrey
force-pushed
the
516-demo-reply-errors
branch
from
8ef0e6d to
8c09265
Compare
maurolacy
approved these changes
Oct 28, 2021
| let parsed = parse_instantiate_response_data(res.data.unwrap().as_slice()).unwrap(); | ||
| assert!(parsed.data.is_some()); | ||
| // from the reply, not the top level | ||
| assert_eq!(parsed.data.unwrap(), Binary::from(b"babble")); |
Contributor
There was a problem hiding this comment.
Just curious, what about the top level data?
Contributor
Author
There was a problem hiding this comment.
The contract returned "remove-me" on the message, it was overwritten with "babble" via the reply.
This is what I wanted to test. I guess the comment could be improved
maurolacy
force-pushed
the
516-demo-reply-errors
branch
from
8c09265 to
7b3b1cf
Compare
maurolacy
reviewed
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Par one of #516
This properly handles the instantiate wrapping, even when they set data in reply.
I started working on the envelope for WasmMsg::Execute and WasmMsg::Migrate, but that broke quite some tests. Let's merge this first (as it caused issues testing some PRs) and then do the exec ones in a follow up PR.