Conversation
hashedone
approved these changes
Sep 23, 2021
Contributor
hashedone
left a comment
hashedone
left a comment
There was a problem hiding this comment.
Very trivial extending case, good starting point showing that this approach makes extension easier without going into some complicated cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #440 and #445
It was requested to have something out of the box that works like Ethereum with a "metadata uri".
I added a new contract that just extends
cw721-baseto demonstrate how to easily add that (or any other metadata). It also let me do a bit of cleanup on the interfaces and how we export objects.Look at the README for a better description