Document submsg data failures and fix them#383
Merged
Conversation
Closed
Corrected submessage data response handling in multi-test
ethanfrey
changed the title
Closed
hashedone
approved these changes
Aug 10, 2021
Contributor
hashedone
left a comment
hashedone
left a comment
There was a problem hiding this comment.
Tests looks ok for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #382 first
This takes some of the work from #381 and extends it to generate a proper test suite for the reply data tests.
4 tests fail here. Do not fix them on this branch. Rather make a PR from another branch onto this which fixes those tests and we can look at tests and solutions separately.