Merged
Conversation
Contributor
Author
|
I'm now thinking that this can be improved by using |
ethanfrey
reviewed
Jul 21, 2021
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Nice overview.
I added a few comments for improvements.
I would love it if @orkunkl could try reading it and give his feedback (as he has not been working on coding these types) to ensure we are not missing something obvious
ethanfrey
approved these changes
Jul 21, 2021
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Good stuff. Thanks for the updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation / closure of #327.