Skip to content

Replace byte slices by string slices in names and constructors#173

Merged
ethanfrey merged 1 commit intomasterfrom
byte-slices-to-str
Dec 11, 2020
Merged

Replace byte slices by string slices in names and constructors#173
ethanfrey merged 1 commit intomasterfrom
byte-slices-to-str

Conversation

@maurolacy
Copy link
Copy Markdown
Contributor

@maurolacy maurolacy commented Dec 11, 2020 •
edited
Loading

Closes #170.

I focused in names & ctors. Possibly other things can be changed as well, in other PR / PRs:

  • key(), prefix()
  • to_length_prefixed()
  • nested_namespace_with_keys()
  • load(), update(), save(), may_load(), ...
  • Bound
  • ...

@maurolacy maurolacy requested a review from ethanfrey December 11, 2020 20:56
ethanfrey
ethanfrey approved these changes Dec 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@ethanfrey ethanfrey merged commit 940775a into master Dec 11, 2020
@ethanfrey ethanfrey deleted the byte-slices-to-str branch December 11, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ethanfrey ethanfrey ethanfrey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update namespaces / constructors to accept &str

2 participants

@maurolacy @ethanfrey