Merged
Conversation
ethanfrey
force-pushed
the
snapshot-cw4
branch
from
90326bd to
dc8ceb6
Compare
Snapshot module
maurolacy
reviewed
Dec 10, 2020
maurolacy
reviewed
Dec 10, 2020
Contributor
maurolacy
left a comment
maurolacy
left a comment
There was a problem hiding this comment.
Looks pretty good. Nice how "subclassing" of SnapshotMap from Map made the code changes straightforward here.
I also think this version is better / simpler, as it requires less interactions.
maurolacy
approved these changes
Dec 10, 2020
ethanfrey
force-pushed
the
snapshot-cw4
branch
from
dc8ceb6 to
48f6780
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
I think this implements the version you preferred. Snapshotting in cw4-group and not relying on the hooks.
It does seem simpler (now that I put all the work into #161). Happy for your feedback or suggestions how to improve it.
I considered a new PR to investigate allowing only selected checkpoints for less writes. But this doesn't work in cw4-group, because who do we trust to control these? By removing old snapshots, you could invalidate a proposal in progress...