Properly cache wasm code#135
Merged
ethanfrey merged 10 commits intorouter-with-rollbacksfrom Nov 6, 2020
Merged
Conversation
6 tasks
ethanfrey
force-pushed
the
router-with-rollbacks
branch
from
bb6bb3f to
a2b075c
Compare
ethanfrey
force-pushed
the
try-to-set-cache
branch
from
c065dbc to
b16ba82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This compiles and tests pass. Major changes in all the data structures to handle the transactional concept.
It definiely needs a review and cleanup before merging it into the router-with-rollback. And that a second round as well before making master.