Add TokensByOwner for cw721-base#122
Conversation
2e034ea to
6614068
Compare
maurolacy
left a comment
There was a problem hiding this comment.
Looks good. I think the use of bounds is still a little bit confusing / needlessly complex.
Added some comments to try and help clarifying the design.
|
My takeaways. Only use one type: and accept This will lead to lines like: `let start: Option = start_after.map(|human| Ok(Bound::Exclusive(deps.api.canonical_addr(&human)?)).transpose()?; Which is not so legible or user-friendly. I guess having a function for handling the
or
both of which are simple enough, without all these helpers. Does the above make sense to you? Other suggestion? |
|
Makes sense. Will review later again with the IDE, to see and try some variants. |
maurolacy
left a comment
There was a problem hiding this comment.
I understand this is WIP, but what I see looks good to me.
Powerful stuff here, and in the storage-plus.
b989e6d to
ae42b7d
Compare
ae42b7d to
6465625
Compare
Closes #81
Builds on #108 (merge that first)
Ports to use
cw-storage-plusrather thancosmwasm-storage, then makes use of IndexedMapcw-storage-plusIndexedMap