Schema codegen #2508
Open
Schema codegen #2508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aumetra
force-pushed
the
aw/codegen
branch
3 times, most recently
from
1b2bcfb to
1ddefa1
Compare
aumetra
force-pushed
the
aw/codegen
branch
2 times, most recently
from
434d799 to
bb024bd
Compare
aumetra
force-pushed
the
aw/codegen
branch
2 times, most recently
from
9d27401 to
b4662af
Compare
chipshort
reviewed
Jun 27, 2025
| cw_schema::NodeType::Double => "z.number()".into(), | ||
| cw_schema::NodeType::Boolean => "z.boolean()".into(), | ||
| cw_schema::NodeType::String => "z.string()".into(), | ||
| cw_schema::NodeType::Integer { .. } => "z.string().or(z.number())".into(), // TODO: is this correct? |
There was a problem hiding this comment.
It seems with the way this whole thing is set up, we cannot distinguish between stringified integers (like Uint128, etc.) and normal ones (like u128). Probably should have caught that during the review without codegen.
| {{ doc }} | ||
| {% endfor %}""" | ||
| {% for field in fields %} | ||
| {{ field.name }}: {{ field.ty }} |
There was a problem hiding this comment.
Ultimately we need some sort of handling for keywords here. E.g. the crypto-verify contract uses from as a field name, which causes invalid python code to be generated here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.