Store engine together with Module to mitigate memory increase issue #1982
Conversation
| /// The runtime engine to run this module. Ideally we could use a single engine | ||
| /// for all modules but the memory issue described in <https://github.com/wasmerio/wasmer/issues/4377> | ||
| /// requires using one engine per module as a workaround. | ||
| pub engine: Engine, |
There was a problem hiding this comment.
We should update the docs for size_estimate too. It still mentions "Store/Engine are not cached anymore".
Also: Don't we need to update the code for size_estimate now that we store the engine again?
There was a problem hiding this comment.
Very good points. Was thinking about them before but then forgot. Should be addressed in the last commit. Once approved, I can squash the patch commits for easy porting and add a CHANGELOG entry.
Thanks for the confirmation! I did not test it yet |
webmaster128
force-pushed
the
one-engine-per-module
branch
from
b7ef836 to
1b110c6
Compare
|
@Mergifyio backport release/1.5 release/1.4 |
✅ Backports have been created
|
Store engine together with Module to mitigate memory increase issue (backport #1982)
Store engine together with Module to mitigate memory increase issue (backport #1982)
Closes #1978