Skip to content

Update wasmer to 2.3.0 #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 13, 2022
Merged

Update wasmer to 2.3.0 #1360

merged 5 commits into from
Jul 13, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Jul 13, 2022

Closes #1353

@uint uint requested review from webmaster128 and ueco-jb July 13, 2022 12:29
webmaster128
webmaster128 reviewed Jul 13, 2022
View reviewed changes
webmaster128
webmaster128 reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a CHANGELOG entry?

@uint
Copy link
Contributor Author

uint commented Jul 13, 2022

Seems the new Wasmer doesn't agree with our MSRV:

error: package `corosensei v0.1.3` cannot be built because it requires rustc 1.59.0 or newer, while the currently active rustc version is 1.56.1

@uint
Copy link
Contributor Author

uint commented Jul 13, 2022

Should I update the 1.56.1 CI job to 1.59.0?

@webmaster128
Copy link
Member

Should I update the 1.56.1 CI job to 1.59.0?

Yeah, sounds reasonable.

@uint uint modified the milestone: 1.1.0 Jul 13, 2022
@uint uint merged commit 690006e into main Jul 13, 2022
@uint uint deleted the wasmer-2-3-0 branch July 13, 2022 15:01
@webmaster128 webmaster128 mentioned this pull request Jul 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ueco-jb ueco-jb Awaiting requested review from ueco-jb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Wasmer to 2.3.0
2 participants
@uint @webmaster128