Skip to content

Don't ignore the package's README #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Don't ignore the package's README #230

merged 1 commit into from
Aug 20, 2025

Conversation

msanatan
Copy link
Contributor

@msanatan msanatan commented Aug 20, 2025 •
edited by coderabbitai bot
Loading

Fixes error here noticed while testing: https://discord.com/channels/1330955894296543364/1407837016493789318/1407838019863449612

Summary by CodeRabbit

  • Chores
    • Updated version-control ignore rules to allow tracking of a documentation asset’s Unity metadata.
    • Added the corresponding Unity metadata file to source control so the asset is recognized correctly in the Unity Editor across environments.
    • Ensures consistent project setup and prevents accidental omission of the asset in collaborative workflows.
    • No functional changes to the application; this is a repository housekeeping update to improve Unity asset management.

@msanatan msanatan self-assigned this Aug 20, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Removed the ignore rule for README.md.meta in .gitignore and added a new Unity meta file UnityMcpBridge/README.md.meta to track README.md as a Unity asset. No code or API changes.

Changes

Cohort / File(s) Summary of Changes
Git ignore update
/.gitignore		 Removed README.md.meta from Unity-specific ignore entries so it will be tracked if present.
Unity meta addition
/UnityMcpBridge/README.md.meta		 Added Unity meta file for README.md with GUID and TextScriptImporter metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of bytes, a hop through git’s glade,
I unhid a meta where README is made.
With GUIDs aligned and footprints so neat,
The project now tracks each document’s beat.
Thump-thump! says the rabbit—merge feels complete. 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ae13ef4 and d767168.

📒 Files selected for processing (2)
  • .gitignore (0 hunks)
  • UnityMcpBridge/README.md.meta (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msanatan msanatan merged commit eeb67e8 into CoplayDev:main Aug 20, 2025
1 check was pending
@msanatan msanatan deleted the fix-readme-error-2 branch August 20, 2025 22:26
@msanatan msanatan mentioned this pull request Aug 20, 2025
Closed
dsarno added a commit to dsarno/unity-mcp that referenced this pull request Aug 25, 2025
@dsarno
Merge branch 'fix/installer-cleanup-v2' into feat/pre-split-edit-fram…
dbc65a5 
…ing-testes

* fix/installer-cleanup-v2:
  Server: set server_version.txt to 3.0.1
  MCP: Fix macOS paths and VSCode manual setup
  refactor(installer): revert to lean installer logic from ee23346; fix macOS path via Application.platform; escape pgrep pattern
  feat(installer): rewire known configs (EditorPrefs, Cursor mcp.json) to canonical path; then remove legacy if unreferenced
  chore(version): bump server_version.txt to 3.0.5
  fix(installer): use Application.platform for OS detection; add canonical root logs; fallback to RuntimeInformation
  chore(logging): include OS and server version in MCP bridge start log
  chore(server): bump server_version.txt to 3.0.4
  bump server version
  sec(installer): escape server path in pgrep pattern to prevent injection/regex issues
  chore(editor): WriteToConfig honors pythonDir; robust config match; remove unused helpers
  fix(installer): skip legacy deletion when still referenced in prefs or Cursor config
  Improve Windsurf MCP Config (CoplayDev#231)
  feat: installer cleanup, auto-migration, logging normalization
  chore: bump version to 3.0.0
  Don't ignore the package's README (CoplayDev#230)
  Rename namespace and public facing plugin output from "Unity MCP" to "MCP for Unity" (CoplayDev#225)

# Conflicts:
#	UnityMcpBridge/Editor/Tools/ManageScript.cs
#	UnityMcpBridge/Editor/Windows/MCPForUnityEditorWindow.cs
#	UnityMcpBridge/UnityMcpServer~/src/server.py
#	UnityMcpBridge/UnityMcpServer~/src/tools/__init__.py
#	UnityMcpBridge/UnityMcpServer~/src/uv.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msanatan msanatan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msanatan