added results #182
Merged
added results #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
reviewed
Apr 19, 2024
| @@ -42,7 +43,9 @@ export default function ShareResultsModal({ | |||
| ? 'Share or save your quiz results through email or using the link below.' | |||
| : 'Share or save your quiz results with this link.'} | |||
| </div> | |||
| {onEmailResults && <EmailField onSubmit={(email) => onEmailResults({ email, url })} />} | |||
| {onEmailResults && ( | |||
| <EmailField onSubmit={(email) => onEmailResults({ email, url, results })} /> | |||
There was a problem hiding this comment.
The name results might be a bit confusing here since results is actually the response object that we get from the API which has request and response which has results under it 😅
We can either rename this to something else and keep exposing the same value or alternatively we can expose quizState.results.response.results. I am okay with both. What do you think @v-i-s-h-n-u-ps ?
There was a problem hiding this comment.
It seems enough to expose quizState.results.response.results. Updated 9cffc91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.