Skip to content

[QUIZ-723]: subtask tests for rest of the files #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Apr 17, 2024
Merged

[QUIZ-723]: subtask tests for rest of the files #180

merged 40 commits into from
Apr 17, 2024

Conversation

dmitrycnstrc
Copy link
Contributor

@dmitrycnstrc dmitrycnstrc commented Mar 29, 2024 •
edited
Loading

Have added tests for hooks server & client and utils

@dmitrycnstrc dmitrycnstrc marked this pull request as ready for review April 1, 2024 13:58
v-i-s-h-n-u-ps
v-i-s-h-n-u-ps suggested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@v-i-s-h-n-u-ps v-i-s-h-n-u-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gull-Dev Thank you for covering more files with unit tests. A couple of things, Can we keep same file structure as we've in src for the tests. Also, useQuizApiState.ts, useSelectInputProps.ts can use more coverage.

@esezen esezen merged commit 0d60c66 into main Apr 17, 2024
@esezen esezen deleted the QUIZ-723/subtask-tests-for-rest-of-the-files branch April 17, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esezen esezen esezen approved these changes

@mocca102 mocca102 Awaiting requested review from mocca102 mocca102 is a code owner

@vladconstructor vladconstructor Awaiting requested review from vladconstructor

+1 more reviewer

@v-i-s-h-n-u-ps v-i-s-h-n-u-ps v-i-s-h-n-u-ps approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrycnstrc @esezen @v-i-s-h-n-u-ps