-
Notifications
You must be signed in to change notification settings - Fork 2
[CDX-217] Add Sale Price Conditional Check #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CDX-217] Add Sale Price Conditional Check #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @evanyan13 for working on that!
I left some minor comments, please let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a minor comment, please let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the PR! A small edge case consideration before we ship this.
Hi @Mudaafi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for making the changes!
Objective
sale_price
andprice
sale_price
when it is strictly less thanprice
Definition of Done
sale_price
and its UI when it is strictly less thanprice