Skip to content

Conversation

evanyan13
Copy link
Contributor

@evanyan13 evanyan13 commented Aug 20, 2025

Objective

  • As user of PLP library I want to add a conditional check to safeguard against situations where we are mistakenly passing the same value to both sale_price and price
  • As CDX, I want to implement a logic to only render sale_price when it is strictly less than price

Definition of Done

  • Add conditional check to only render sale_price and its UI when it is strictly less than price
  • Add tests

@evanyan13 evanyan13 requested a review from a team August 20, 2025 01:18
@evanyan13 evanyan13 self-assigned this Aug 20, 2025
Copy link

@TarekAlQaddy TarekAlQaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evanyan13 for working on that!
I left some minor comments, please let me know what you think

@evanyan13 evanyan13 requested a review from TarekAlQaddy August 20, 2025 19:22
Copy link

@TarekAlQaddy TarekAlQaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment, please let me know what you think

Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR! A small edge case consideration before we ship this.

@evanyan13
Copy link
Contributor Author

Hi @Mudaafi
Thank you for the review!
I have addressed some of the lint issues.
Have also left my comment for the edge case consideration. Would like to hear your thoughts about it!

Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making the changes!

@evanyan13 evanyan13 merged commit dcd0c13 into main Aug 28, 2025
11 checks passed
@evanyan13 evanyan13 deleted the cdx-217-plp-ui-add-saleprice-conditional-check branch August 28, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants