Skip to content

[CDX-169] Support Sale pricing #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2025
Merged

[CDX-169] Support Sale pricing #169

merged 4 commits into from
Jul 25, 2025

Conversation

ZSnake
Copy link
Contributor

@ZSnake ZSnake commented Jul 17, 2025 •
edited
Loading

  • Add logic to handle sale_price
  • Add product card styling for sale price
  • Add custom itemFieldGetter to define where to get sale price from
  • Add storybook example and test cases
image

Add logic to handle sale_price, add custom itemFieldGetter to define …
1296d24 
…where to get sale price from, add storybook example and test cases
@ZSnake ZSnake requested a review from a team as a code owner July 17, 2025 08:41
@evanyan13 evanyan13 self-requested a review July 18, 2025 20:30
evanyan13
evanyan13 reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@evanyan13 evanyan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! 💯 @ZSnake
Left quite a few comments for your consideration please.
Thank you!

@ZSnake ZSnake requested review from Mudaafi and HHHindawy as code owners July 22, 2025 17:11
@ZSnake ZSnake requested a review from evanyan13 July 22, 2025 17:33
evanyan13
evanyan13 approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@evanyan13 evanyan13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working for this. 💯
Left one comment below for your consideration.
Please get a review from Ahmad as well!
Thank you!

Mudaafi
Mudaafi requested changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mainly around tests! The implementation looks good 👍

We'll also want to update the ProductInfo table under the ProductCard RenderProps.md as well.

[CDX-169] Fix mock object data, refactor test to check all properties…
56a936c 
… on products with and without sale price, refactor salePrice assignment on useProducts hook, update RenderProps tabel on product card documentation
@ZSnake ZSnake requested a review from Mudaafi July 24, 2025 18:03
Mudaafi
Mudaafi approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making the changes!

@ZSnake ZSnake merged commit 2987814 into main Jul 25, 2025
10 of 11 checks passed
@ZSnake ZSnake deleted the cdx-169-os-plp-ui-support-sale-pricing branch July 25, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mudaafi Mudaafi Mudaafi approved these changes

@evanyan13 evanyan13 evanyan13 approved these changes

@HHHindawy HHHindawy Awaiting requested review from HHHindawy HHHindawy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZSnake @Mudaafi @evanyan13