[CI-4410] Send correct variationId to onAddToCart callback, add test #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocca102
reviewed
May 5, 2025
| @@ -93,6 +93,25 @@ describe('Testing Component: ProductCard', () => { | |||
| expect(contextOnAddToCart).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| test('Should run custom onAddToCart handler if overridden at the CioPlp provider level', () => { | |||
There was a problem hiding this comment.
Now we have two tests with the same description. Would it be better if we merge both tests into one test?
"Should run custom onAddToCart handler if overridden at the CioPlp provider level"
esezen
approved these changes
May 6, 2025
Mudaafi
deleted the
ci-4410-os-plp-ui-incorrect-variation-id-sent-in-onaddtocart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the expected call signature for the custom
onAddToCartcallback:Since this modification only adds an optional parameter, it is a backwards compatible change.