Skip to content

Conversation

evanyan13
Copy link
Contributor

@evanyan13 evanyan13 commented Apr 18, 2025

  • Update code examples for Pagination component
    • Basic Example
    • Render Props Example

@evanyan13 evanyan13 self-assigned this Apr 18, 2025
@evanyan13 evanyan13 requested a review from a team as a code owner April 18, 2025 03:55
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked when you added instructions for how to view the example and see the component in action in CioPlp? Can we do something similar here? Maybe an example with search or browse @evanyan13

To view the examples and see this component in action, append your URL with /group_id/1035, as this corresponds to a Browse Page.

Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a small comment. Let me know what you think

@evanyan13 evanyan13 merged commit 40eb056 into main May 1, 2025
9 of 11 checks passed
@evanyan13 evanyan13 deleted the ci-4303-os-plp-ui-docs-fix-code-examples-pagination branch May 1, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants