Skip to content

Conversation

evanyan13
Copy link
Contributor

@evanyan13 evanyan13 commented Apr 17, 2025

  • Update code examples for Filters component
    • Basic Example
    • Render Props Example

@evanyan13 evanyan13 self-assigned this Apr 17, 2025
@evanyan13 evanyan13 requested a review from a team as a code owner April 17, 2025 04:01
@evanyan13 evanyan13 changed the title [CI-4373] Update Code Examples - Filters [CI-4303] Update Code Examples - Filters Apr 17, 2025
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked when you added instructions for how to view the example and see the component in action in CioPlp? Can we do something similar here? Maybe an example with search or browse @evanyan13

  • To view the examples and see this component in action, append your URL with /group_id/1035, as this corresponds to a Browse Page.

Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one small comment

@evanyan13 evanyan13 merged commit c833d0b into main May 1, 2025
10 of 11 checks passed
@evanyan13 evanyan13 deleted the ci-4373-os-plp-ui-docs-fix-filters-code-examples branch May 1, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants