Skip to content

[CI-4303] Update Code Example - CioPlpGrid #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2025
Merged

[CI-4303] Update Code Example - CioPlpGrid #150

merged 5 commits into from
May 1, 2025

Conversation

evanyan13
Copy link
Contributor

@evanyan13 evanyan13 commented Apr 16, 2025 •
edited
Loading

  • Update code examples for CioPlpGrid component
    • Basic Example
    • Render Props Example

@evanyan13 evanyan13 self-assigned this Apr 16, 2025
@evanyan13 evanyan13 requested a review from a team as a code owner April 16, 2025 23:13
@evanyan13 evanyan13 changed the title [CI-4372] [CI-4372] Update CioPlpGrid Code Example Apr 16, 2025
@evanyan13 evanyan13 changed the title [CI-4372] Update CioPlpGrid Code Example [CI-4372] Update Code Example - CioPlpGrid Apr 17, 2025
@evanyan13 evanyan13 changed the title [CI-4372] Update Code Example - CioPlpGrid [CI-4303] Update Code Example - CioPlpGrid Apr 17, 2025
mocca102
mocca102 reviewed Apr 21, 2025
View reviewed changes
mocca102
mocca102 requested changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

mocca102
mocca102 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Mudaafi
Mudaafi reviewed Apr 30, 2025
View reviewed changes
Mudaafi
Mudaafi reviewed Apr 30, 2025
View reviewed changes
Mudaafi
Mudaafi reviewed May 1, 2025
View reviewed changes
src/stories/components/CioPlpGrid/RenderProps.md Outdated
| -------------- | ------------------------------ | -------------------------------------------- | --------------- | ------------------------------- |
| resultId | `string` | Result ID of the response |
| request | `SearchRequestType` | API returned request object |
| response | `Nullable<PlpSearchDataResults | PlpSearchDataRedirect | PlpBrowseData>` | API transformed response object |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirect is a separate field. See SearchResultsReturn

Mudaafi
Mudaafi approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@Mudaafi Mudaafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment below

@evanyan13 evanyan13 merged commit 81aeb44 into main May 1, 2025
9 of 11 checks passed
@evanyan13 evanyan13 deleted the ci-4372-os-plp-ui-docs-fix-cioplpgrid-code-examples branch May 1, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mudaafi Mudaafi Mudaafi approved these changes

@mocca102 mocca102 mocca102 approved these changes

Assignees

@evanyan13 evanyan13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanyan13 @Mudaafi @mocca102