fix: code optimization Update fetchNodeSize.js#916
Closed
famouswizard wants to merge 2 commits intoConsensys:mainfrom
Closed
fix: code optimization Update fetchNodeSize.js#916famouswizard wants to merge 2 commits intoConsensys:mainfrom
famouswizard wants to merge 2 commits intoConsensys:mainfrom
Conversation
|
@famouswizard is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jlwllmr
reviewed
Jan 6, 2025
Contributor
jlwllmr
left a comment
jlwllmr
left a comment
There was a problem hiding this comment.
This looks good as far as I can see @famouswizard, thank you. As you can see, there are a few linter errors, though — could you resolve please?
Contributor
Author
That's all I can do. |
Contributor
|
@famouswizard to clarify, you're unable to address the linter issues? let me know if I can help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration File Read Once, Efficient calculateDailyIncrease Handling, Error Handling and Data Validation, Reduced File I/O
P.S. Comments added