Improved version strings #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support version tracking in apm
Use git rev-parse and describe to pull commit sha and tag information for use in version string.
|
Bumped python to 3.9. At this point it's 5 months stable, and I'd like to be able to use the walrus operator. |
devinmatte
approved these changes
Mar 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the version string fancier, as well as defining DD_VERSION so we can track versions better in APM and RUM.
Using tags to generate version strings does mean we will need to tag new releases before the OKD build starts. @devinmatte opinions on this? I can switch it back to using the package.json for the version number, if you'd rather keep using the webhook for builds.