Skip to content

Using GitHub actions ci #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2020
Merged

Using GitHub actions ci #231

merged 2 commits into from
Dec 23, 2020

Conversation

devinmatte
Copy link
Member

@devinmatte devinmatte commented Dec 23, 2020 •
edited
Loading

Removes Travis and adds 3 GitHub ci jobs

@devinmatte devinmatte marked this pull request as draft December 23, 2020 19:56
@devinmatte devinmatte marked this pull request as ready for review December 23, 2020 20:08
mxmeinhold
mxmeinhold reviewed Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe squash the fix commits, then 🚢 🇮🇹

@devinmatte devinmatte requested a review from adamhb123 December 23, 2020 20:31
adamhb123
adamhb123 approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@adamhb123 adamhb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinmatte devinmatte merged commit d10b57a into develop Dec 23, 2020
@devinmatte devinmatte deleted the github-actions branch December 23, 2020 20:43
@mxmeinhold mxmeinhold mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmeinhold mxmeinhold mxmeinhold left review comments

@adamhb123 adamhb123 adamhb123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinmatte @mxmeinhold @adamhb123