-
Notifications
You must be signed in to change notification settings - Fork 1
Initial Backend #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bc6b292
to
f5876e6
Compare
After a terrible adventure trying to use nicer tools than raw sql to access the db while having very little bandwidth to explore documentation, we're relegated to using raw sql
Need to fill in a lot more data, but this is the basis
Have to assemble clues by their parent child relationships
No support for rules yet
f5876e6
to
67cfbef
Compare
each request works, maybe we could add checking so names are unique? Not super necessary because the searching could be from tags, but searching by name would make the most sense for a user. |
Yeah, we definitely need to add more constraints in the db |
I think it’s in a good state for now for Main at least, I will probably make CRUD and like search in a separate branch |
Adding windows db migration commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit. Please write tests sooner rather than later.
* Be sure to defer logger.Sync() to ensure it's flushed before we exit | ||
*/ | ||
func GetLogger(ctx context.Context) *zap.Logger { | ||
// TODO we should probably handle the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you should.
) | ||
|
||
const ( | ||
connStr = "postgres://postgres:test@localhost:5432/postgres?sslmode=disable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this hardcoded in the app? Guessing the config will override it but not how I typically do things.
rw.Write(data) | ||
}) | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice comments. Could you do that for the other routes above ☝🏻
Initial setup for the backend, including db migrations, configuration, logging, tracing, and routes for interacting with cluesheets, clues, and user participation. A great deal is not implemented and a great deal is subject to change, but let's get something into main shall we?