-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix TokenizingTextBox header to behave like normal text control headers #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TokenizingTextBox header to behave like normal text control headers #4101
Conversation
Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@@ -95,10 +111,7 @@ | |||
Margin="{StaticResource TokenizingTextBoxPresenterMargin}" | |||
Footer="{TemplateBinding Footer}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want Footer
be also abstracted here? Otherwise it'll be in the TextBox part again, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funnily, in my testing, setting the footer does not actually change anything. So should we move the footer out of the ItemsControl like the header too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think while we're at it here, it makes sense. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@michael-hawker I see that this was removed from the Bugs7.1 board, but the related issue is on that board, is there are reason that this PR is not on the board? |
@RosarioPulella we only put PRs on the board that have no corresponding issue. If there's an issue for the PR, then the issue is what stays on the board. If we have both a PR and an issue on the board the board gets cluttered with duplicates. 🙂 That's why we also set the milestone, as the PR is still in the 7.1 milestone to match too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chingucoding for fixing this! 🎉🎉🎉
Fixes #4096
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Header rendered inside the TokenizingTextBox
What is the new behavior?
Header now renders above the TokenizingTextBox input area.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Also took the liberty to add the properties for the header presenter that are also present for the TextBox header presenter.