Split Markdown.* from Controls package.

[azchohfi]

Created a new Microsoft.Toolkit.Uwp.UI.Controls.Markdown package, moving the MarkdownTextBlock from the Controls package and decoupling the TextToolbar from the MarkDownFormatter.

Helps with #3145

PR Type

What kind of change does this PR introduce?

• Refactoring

What is the current behavior?

Having a dependency on Microsoft.Toolkit.Uwp.UI.Controls pulls too many packages and dependencies.

What is the new behavior?

Microsoft.Toolkit.Uwp.UI.Controls no longer has a dependency on ColorCode.UWP, nor on the Microsoft.Toolkit.Parsers package.

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

If you are using MarkdownTextBlock, or the TextToolbar with Format = Format.Markdown, you will need to add a dependency to the new Microsoft.Toolkit.Uwp.UI.Controls.Markdown. The MarkdownTextBlock implementation is unchanged, but the TextToolbar no longer has a Format property. The markdown parser is now provided just as any other custom parser, and need to be added in Xaml, or code behind. For example:

<Page 
...
      xmlns:markDown="using:Microsoft.Toolkit.Uwp.UI.Controls.TextToolbarFormats.MarkDown"
      xmlns:richText="using:Microsoft.Toolkit.Uwp.UI.Controls.TextToolbarFormats.RichText"
...
>
...
<controls:TextToolbar ...>
      <controls:TextToolbar.Formatter>
        <richText:RichTextFormatter />
        <!--<markDown:MarkDownFormatter />-->
        <!--<local:CustomFormatter />-->
      </controls:TextToolbar.Formatter>
</controls:TextToolbar>
...

[ghost]

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[michael-hawker]

@QuinnDamerell @paulbartrum your contribution of the MarkdownTextBlock was before my time. I just noticed we had the about.txt file here. Though it looks like you contributed directly, so that was a relicense to the MIT at that time I assume? @deltakosh?

For consistency, I'd like to move this attribution instead to our ThirdPartyNotice file:

QuinnDamerell/UniversalMarkdown (https://github.com/QuinnDamerell/UniversalMarkdown) contributed by Quinn Damerell and Paul Bartrum for the MarkdownTextBlock control, relicensed to this .NET Foundation project under the MIT license upon contribution.

FYI @clairernovotny.

[michael-hawker]

@Kyaa-dost was thinking we maybe want another project board to track our more 'backlog'/'debt' items. Like we have a feature/bug board, but this is neither. So maybe we want a 'Technical' bucket for 7.0? And we can use that to track all these breaking changes and other project/repo related work?

[ghost]

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

[paulbartrum]

@QuinnDamerell @paulbartrum your contribution of the MarkdownTextBlock was before my time. I just noticed we had the about.txt file here. Though it looks like you contributed directly, so that was a relicense to the MIT at that time I assume? @deltakosh?

I contributed directly to the UniversalMarkdown project, @QuinnDamerell as the project owner can speak to licensing.

[vgromfeld]

[michael-hawker]

Hi @paulbartrum looks like we don't have a CLA sign-off on file from you from the original PR contribution where Quinn re-assigned the code. Would you mind signing our CLA here now so that we can just clean-up the history here for the future? Thanks!

[paulbartrum]

Hi @paulbartrum looks like we don't have a CLA sign-off on file from you from the original PR contribution where Quinn re-assigned the code. Would you mind signing our CLA here now so that we can just clean-up the history here for the future? Thanks!

Sure @michael-hawker, done.

[michael-hawker]

Thanks so much @paulbartrum! That's a great help for resolving this scenario!

[michael-hawker]

Think we're all clear and good to go now! I'll follow-up on anything else later if need be, but think we should be unblocked here.

[ghost]

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.