Skip to content

Conversation

michael-hawker
Copy link
Member

Want to see if the UWP test passes in the CI (WinAppSDK won't work locally as test point is out of place, so expect that to fail.)

Based off of #156, so don't look at changes here until that's merged to main.

@michael-hawker
Copy link
Member Author

Looks like we're also hitting microsoft/WindowsAppSDK#2631 (at least in the experiment job trying to run the tests against the WinAppSDK head). Put details in the issue and will follow-up.

Fixing build issues and trying again to see if I can get results from UWP tests.

@michael-hawker michael-hawker force-pushed the llama/input-injection branch from e1b1253 to eaf92be Compare June 22, 2022 19:40
@michael-hawker
Copy link
Member Author

Failing do to the linked issue, so we need to wait for 1.1.2 of the WindowsAppSDK here. But this was interesting to see on the UWP test results at least:

Passed InputInjection_TestClickButton_Test [616 ms] 👀

Need to see what happens with the WinAppSDK side of things, as there's another known issue with the Bounds returning different results. Haven't heard back on my e-mail.

But if it's passing in the UWP pipeline, will have to try adding some more tests and seeing what happens. Seems promising! 🤞

FYI @chingucoding as you may find this investigation interesting as well!

@michael-hawker michael-hawker force-pushed the llama/input-injection branch from 4a4d4e2 to eb9200c Compare June 28, 2022 21:40
@michael-hawker michael-hawker changed the title 🚧 Llama/input injection Add rescap to template manifest for future Input Injection work Jun 28, 2022
@michael-hawker michael-hawker marked this pull request as ready for review June 28, 2022 21:41
@michael-hawker
Copy link
Member Author

michael-hawker commented Jun 28, 2022

Alright, actually implementing the Input Injection is blocked on us not being able to migrate to 1.1.1 (waiting on 1.1.2) and even then there may be a MSTest regression still (following up with platform team).

In the meantime, I've rebased this PR to just be the change to the package manifests to add the restricted capability needed. This will enable us to add InputInjection later without needing to modify new experiments (as everything will be encapsulated in the common folder outside of newly written tests using that new functionality).

For now I've put my current (yet not completely functional) work in the llama/input-injection-test branch.

Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious issues, looks good.

@michael-hawker michael-hawker merged commit af1b05f into main Jun 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the llama/input-injection branch June 29, 2022 21:55
Arlodotexe added a commit that referenced this pull request Jul 29, 2022
Add missing rescaps as missed adding to template in #161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants