fix: address CodeRabbit review feedback

- Assert cleanup response in E2E test beforeEach
- Guard downloadUrl type in fetchCivitaiMetadata predicate
- Pass directory resolver unconditionally for OSS model categorization
- Add abort controller to OSS branch for stale workflow protection

Author: jaeone94

browser_tests/tests/dialog.spec.ts

@@ -95,9 +95,11 @@ test.describe('Missing models in Error Tab', () => {
       'Comfy.RightSidePanel.ShowErrorsTab',
       true
     )
-    await comfyPage.page.evaluate((url: string) => {
-      return fetch(`${url}/api/devtools/cleanup_fake_model`)
+    const cleanupOk = await comfyPage.page.evaluate(async (url: string) => {
+      const response = await fetch(`${url}/api/devtools/cleanup_fake_model`)
+      return response.ok
     }, comfyPage.url)
+    expect(cleanupOk).toBeTruthy()
   })
 
   test('Should show error overlay with missing models when workflow has missing models', async ({

src/platform/missingModel/missingModelDownload.ts

@@ -97,9 +97,14 @@ async function fetchCivitaiMetadata(url: string): Promise<ModelMetadata> {
     if (!res.ok) return { fileSize: null, gatedRepoUrl: null }
 
     const data: CivitaiModelVersionResponse = await res.json()
-    const matchingFile = data.files?.find(
-      (file) => file.downloadUrl.startsWith(url) && file.downloadUrl
-    )
+    const matchingFile = data.files?.find((file) => {
+      const downloadUrl = file.downloadUrl
+      return (
+        typeof downloadUrl === 'string' &&
+        downloadUrl.length > 0 &&
+        downloadUrl.startsWith(url)
+      )
+    })
     const fileSize = matchingFile?.sizeKB ? matchingFile.sizeKB * 1024 : null
     return { fileSize, gatedRepoUrl: null }
   } catch {

src/scripts/app.ts

@@ -1421,15 +1421,16 @@ export class ComfyApp {
   ): Promise<{ missingModels: ModelFile[] }> {
     const missingModelStore = useMissingModelStore()
 
+    const getDirectory = (nodeType: string) =>
+      useModelToNodeStore().getCategoryForNodeType(nodeType)
+
     const candidates = scanAllModelCandidates(
       this.rootGraph,
       isCloud
         ? (nodeType, widgetName) =>
             assetService.shouldUseAssetBrowser(nodeType, widgetName)
         : () => false,
-      isCloud
-        ? (nodeType) => useModelToNodeStore().getCategoryForNodeType(nodeType)
-        : undefined
+      getDirectory
     )
 
     const modelStore = useModelStore()
@@ -1503,11 +1504,14 @@ export class ComfyApp {
             })
           })
       } else {
+        const controller =
+          missingModelStore.createVerificationAbortController()
         const confirmed = enrichedCandidates.filter((c) => c.isMissing === true)
         if (confirmed.length) {
           api
             .getFolderPaths()
             .then((paths) => {
+              if (controller.signal.aborted) return
               missingModelStore.setFolderPaths(paths)
             })
             .catch((err) => {
@@ -1517,17 +1521,19 @@ export class ComfyApp {
               )
             })
             .finally(() => {
+              if (controller.signal.aborted) return
               useExecutionErrorStore().surfaceMissingModels(confirmed)
             })
 
           void Promise.allSettled(
             confirmed
               .filter((c) => c.url)
               .map(async (c) => {
-                const { fetchModelMetadata } =
-                  await import('@/platform/missingModel/missingModelDownload')
+                const { fetchModelMetadata } = await import(
+                  '@/platform/missingModel/missingModelDownload'
+                )
                 const metadata = await fetchModelMetadata(c.url!)
-                if (metadata.fileSize !== null) {
+                if (!controller.signal.aborted && metadata.fileSize !== null) {
                   missingModelStore.setFileSize(c.url!, metadata.fileSize)
                 }
               })