fix: apply code review feedback

- Remove redundant text-warning-background class on inner span
- Add error overlay visibility assertion for widget mismatch test
- Fix hasValidDirectory to check for non-empty array
- Improve test isolation with explicit mockIsCloud reset
- Extract makeModel helper to module level to reduce duplication
- Add cross-reference comments for extension constants

Author: jaeone94

browser_tests/tests/dialog.spec.ts

@@ -135,6 +135,9 @@ test.describe('Missing models in Error Tab', () => {
 
     const missingModelsTitle = comfyPage.page.getByText(/Missing Models/)
     await expect(missingModelsTitle).not.toBeVisible()
+
+    const errorOverlay = comfyPage.page.locator('[data-testid="error-overlay"]')
+    await expect(errorOverlay).not.toBeVisible()
   })
 
   // Flaky test after parallelization

src/components/rightSidePanel/errors/useErrorGroups.test.ts

@@ -86,6 +86,26 @@ function makeMissingNodeType(
   }
 }
 
+function makeModel(
+  name: string,
+  opts: {
+    nodeId?: string | number
+    widgetName?: string
+    directory?: string
+    isAssetSupported?: boolean
+  } = {}
+) {
+  return {
+    name,
+    nodeId: opts.nodeId ?? '1',
+    nodeType: 'CheckpointLoaderSimple',
+    widgetName: opts.widgetName ?? 'ckpt_name',
+    isAssetSupported: opts.isAssetSupported ?? false,
+    isMissing: true as const,
+    directory: opts.directory
+  }
+}
+
 function createErrorGroups() {
   const store = useExecutionErrorStore()
   const searchQuery = ref('')
@@ -524,26 +544,6 @@ describe('useErrorGroups', () => {
   })
 
   describe('missingModelGroups', () => {
-    function makeModel(
-      name: string,
-      opts: {
-        nodeId?: string | number
-        widgetName?: string
-        directory?: string
-        isAssetSupported?: boolean
-      } = {}
-    ) {
-      return {
-        name,
-        nodeId: opts.nodeId ?? '1',
-        nodeType: 'CheckpointLoaderSimple',
-        widgetName: opts.widgetName ?? 'ckpt_name',
-        isAssetSupported: opts.isAssetSupported ?? false,
-        isMissing: true as const,
-        directory: opts.directory
-      }
-    }
-
     it('returns empty array when no missing models', () => {
       const { groups } = createErrorGroups()
       expect(groups.missingModelGroups.value).toEqual([])
@@ -696,26 +696,6 @@ describe('useErrorGroups', () => {
       mockIsCloud.value = false
     })
 
-    function makeModel(
-      name: string,
-      opts: {
-        nodeId?: string | number
-        widgetName?: string
-        directory?: string
-        isAssetSupported?: boolean
-      } = {}
-    ) {
-      return {
-        name,
-        nodeId: opts.nodeId ?? '1',
-        nodeType: 'CheckpointLoaderSimple',
-        widgetName: opts.widgetName ?? 'ckpt_name',
-        isAssetSupported: opts.isAssetSupported ?? false,
-        isMissing: true as const,
-        directory: opts.directory
-      }
-    }
-
     it('puts unsupported models into UNSUPPORTED group in Cloud', async () => {
       const { store, groups } = createErrorGroups()
       store.surfaceMissingModels([

src/platform/missingModel/components/MissingModelCard.test.ts

@@ -98,6 +98,10 @@ function mountCard(
 }
 
 describe('MissingModelCard', () => {
+  beforeEach(() => {
+    mockIsCloud.value = true
+  })
+
   describe('Rendering & Props', () => {
     it('renders directory name in category header', () => {
       const wrapper = mountCard({

src/platform/missingModel/components/MissingModelCard.vue

@@ -16,10 +16,7 @@
               : 'text-destructive-background-hover'
           "
         >
-          <span
-            v-if="isCloud && !group.isAssetSupported"
-            class="text-warning-background"
-          >
+          <span v-if="isCloud && !group.isAssetSupported">
             {{ t('rightSidePanel.missingModels.importNotSupported') }}
             ({{ group.models.length }})
           </span>

src/platform/missingModel/missingModelDownload.ts

@@ -25,7 +25,7 @@ const WHITE_LISTED_URLS: ReadonlySet<string> = new Set([
   'https://github.com/xinntao/Real-ESRGAN/releases/download/v0.1.0/RealESRGAN_x4plus.pth'
 ])
 
-export interface ModelWithUrl {
+interface ModelWithUrl {
   name: string
   url: string
   directory: string
@@ -40,12 +40,6 @@ export function isModelDownloadable(model: ModelWithUrl): boolean {
   return true
 }
 
-export function hasValidDirectory(
-  model: ModelWithUrl,
-  paths: Record<string, string[]>
-): boolean {
-  return !!paths[model.directory]
-}
 
 export function downloadModel(
   model: ModelWithUrl,
@@ -104,7 +98,7 @@ async function fetchCivitaiMetadata(url: string): Promise<ModelMetadata> {
 
     const data: CivitaiModelVersionResponse = await res.json()
     const matchingFile = data.files?.find(
-      (file) => file.downloadUrl && file.downloadUrl.startsWith(url)
+      (file) => file.downloadUrl.startsWith(url) && file.downloadUrl
     )
     const fileSize = matchingFile?.sizeKB ? matchingFile.sizeKB * 1024 : null
     return { fileSize, gatedRepoUrl: null }
@@ -128,8 +122,10 @@ async function fetchHeadMetadata(url: string): Promise<ModelMetadata> {
       return { fileSize: null, gatedRepoUrl: null }
     }
     const size = response.headers.get('content-length')
+    const parsedSize = size ? parseInt(size, 10) : null
     return {
-      fileSize: size ? parseInt(size, 10) : null,
+      fileSize:
+        parsedSize !== null && !Number.isNaN(parsedSize) ? parsedSize : null,
       gatedRepoUrl: null
     }
   } catch {

src/platform/missingModel/missingModelScan.ts

@@ -46,10 +46,7 @@ export const MODEL_FILE_EXTENSIONS = new Set([
 
 export function isModelFileName(name: string): boolean {
   const lower = name.toLowerCase()
-  for (const ext of MODEL_FILE_EXTENSIONS) {
-    if (lower.endsWith(ext)) return true
-  }
-  return false
+  return Array.from(MODEL_FILE_EXTENSIONS).some((ext) => lower.endsWith(ext))
 }
 
 function resolveComboOptions(widget: IComboWidget): string[] {