Skip to content

Enable Pytorch Attention for AMD gfx1150 (Strix Point)#12973

Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom
lostdisc:gfx1150-enable-pytorch-attention
Mar 15, 2026
Merged

Enable Pytorch Attention for AMD gfx1150 (Strix Point)#12973
comfyanonymous merged 1 commit intoComfy-Org:masterfrom
lostdisc:gfx1150-enable-pytorch-attention

Conversation

@lostdisc
Copy link
Contributor

I've been using --enable-pytorch-cross-attention on gfx1150 for a few months now (after ROCm 7.1.1 came out for Windows with AOTriton). For SDXL it's 15-20% faster than the default attention for me. Seems OK to enable by default?

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8443fdfa-3c8d-4238-8855-60dc5287bd1e

📥 Commits

Reviewing files that changed from the base of the PR and between e84a200 and fc9c7e6.

📒 Files selected for processing (1)
  • comfy/model_management.py

📝 Walkthrough

Walkthrough

The change adds gfx1150 to the AMD GPU architecture list in the attention code path alongside the existing gfx1151 support. This expands which AMD GPUs can utilize PyTorch attention when aotriton is available. The modification is minimal with one line added and one removed, introducing no other behavioral or control-flow changes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: enabling PyTorch attention for AMD gfx1150 architecture.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation and performance benefits of enabling PyTorch attention for gfx1150.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@comfyanonymous comfyanonymous merged commit 3814bf4 into Comfy-Org:master Mar 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants