Memory leak issue with ReplaySubject

[jabeattie]

Hi Folks, we recently started using CombineExt in a project and it's already proven itself invaluable for fixing plenty of common scenarios we wanted to solve, so kudos for that.

We had a need to use share(replay:) recently and noticed after implementing it that we had some retain cycles appearing in our application. After spending some time looking into them, it looks to be caused by ReplaySubject not releasing its subscriptions when they receive a completion.

I've got an idea for a fix, but I'm not well versed enough on Combine yet to appreciate what the other implications of it may be, so any help would be appreciated, thanks.

[jabeattie]

Some screenshots from the memory graph after using the share(replay:) operator