Private/codewithvk/recent doc in starter screen #13866
Open
+87
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: codewithvk <[email protected]> Change-Id: I10fcc6a5dbbdfa2c5d657466b6dc4d94ae676957
codewithvk
force-pushed
the
private/codewithvk/recent_doc_in_starter_screen
branch
from
286d837 to
cc5a087
Compare
Darshan-upadhyay1110
requested review from
Quwex and
stbergmann
and removed request for
Quwex
stbergmann
reviewed
Dec 18, 2025
qt/coda-qt.cpp
Outdated
| lok::Document* loKitDoc = DocumentData::get(_document._appDocId).loKitDocument; | ||
| if (loKitDoc) { | ||
| docType = static_cast<LibreOfficeKitDocumentType>(loKitDoc->getDocumentType()); | ||
| LibreOfficeKitDocumentType docType = LOK_DOCTYPE_OTHER; |
Contributor
There was a problem hiding this comment.
use std::optional<LibreOfficeKitDocumentType>, with an empty one representing "all types", rather than "misusing" LOC_DOCTYPE_OTHER for that?
qt/RecentDocuments.cpp
Outdated
|
|
||
| std::sort(allDocs.begin(), allDocs.end(), | ||
| [](const DocumentEntry& a, const DocumentEntry& b) { | ||
| return a.timestamp > b.timestamp; |
Contributor
There was a problem hiding this comment.
I'd use a predicate here that takes into account all four members of DocumentEntry (so that the non-stable order into which std::sort puts equivalent elements doesn't lead to random results)
Contributor
Author
There was a problem hiding this comment.
Agree, but practically it’s very rare to have the same timestamps. Still, I’ve implemented the ordering like this:
timestamp -> uri -> name -> type
qt/RecentDocuments.cpp
Outdated
| }); | ||
|
|
||
| Poco::JSON::Array::Ptr recentDocs = new Poco::JSON::Array(); | ||
| int limit = qMin(static_cast<int>(allDocs.size()), MAX_RECENT); |
Contributor
There was a problem hiding this comment.
- instead of using a potentially lossy cast of
allDocs.size()toint, play it safe and instead castMAX_RECENTtostd::size_t(or makeMAX_RECENTbe of that type to begin with) and let the resultinglimitbe ofstd::size_t? - instead of
qMin, usestd::min? (and now I notice you already useqMinelsewhere in this file, too, which could be some follow-up cleanup commit)
Signed-off-by: codewithvk <[email protected]> Change-Id: I5df2177f79ac6cb2a833e834dabf87b77347a047
codewithvk
force-pushed
the
private/codewithvk/recent_doc_in_starter_screen
branch
from
cc5a087 to
1f2ef6d
Compare
Signed-off-by: codewithvk <[email protected]> Change-Id: I7dff4ea2372dab2b3031c9c60dc89d5fa98f5b1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay