-
Notifications
You must be signed in to change notification settings - Fork 106
fix: set path variables when trying to run npm commands #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement, thank you
I only request to put this code changes inside of the "// macOS / Linux" else block
2619fce
to
23d508f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
When installing the plugin on MacOS, it fails to use npm. Providing the paths resolves the issue.
This PR fixes npm command execution failures on macOS by ensuring the PATH environment variable includes common npm installation locations. The fix modifies the
RunNpmCommand
method inEditor/Utils/McpUtils.cs
to explicitly set PATH environment variables before executing npm commands.Technical Details
The solution adds
/usr/local/bin
and/opt/homebrew/bin
(common npm installation paths on macOS) to the PATH environment variable when running npm commands. This ensures that the system can locate npm executables even when they're installed in non-standard locations, which is common on macOS systems, especially those using Homebrew.Changes Made
McpUtils.RunNpmCommand()
method to set PATH environment variablesChanges that Break Backward Compatibility
N/A
Documentation
N/A
Created with Palmier