Skip to content

Conversation

@Chemaclass
Copy link
Contributor

@Chemaclass Chemaclass commented May 25, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

We added bashunit here #64 using snapshot testing as example. However, for these concrete tests it make more sense (as it is also simpler to read) to use a simple assert_equals

Snapshots make sense when the output to compare is something bigger/more complex than a number. When comparing a number, snapshot testing might be good for show-case example, but it is an overkilling feature for the long living of the project.

Screenshot 2024-05-25 at 19 51 59

Copy link
Contributor

@johnlk johnlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner. Thanks 🙌🏻

@Chemaclass
Copy link
Contributor Author

Reminder: Can we merge this? :)

@johnlk johnlk merged commit e13c249 into CodelyTV:main Jun 9, 2024
@Chemaclass Chemaclass deleted the feat/upgrade-bashunit branch June 9, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants