Progress reporting broken for async operations without a return value

[trombipeti]

My fix for #353 was not perfect: I get no progress value with "resultless" async methods (public async Task SomeMethod(/* params */ IProgress<int> progress, CancellationToken cancellationToken)

The problem lies here I think:

WampSharp/src/netstandard/WampSharp/WAMP2/V2/Rpc/Callee/Reflection/AsyncMethodInfoRpcOperation.cs

Line 32 in 8fef06c

if (method.ReturnType != typeof (Task))

and

WampSharp/src/netstandard/WampSharp/WAMP2/V2/Rpc/Callee/LocalRpcOperation.cs

Line 80 in 8fef06c

else if (!this.HasResult)

We have a workaround for this issue in our project and I can only start working on this in August, but if you'd have time until then to fix it, I'd be very happy :)

[darkl]

I think I fixed it in 23.5.1-develop-49. Could you try it out and let me know if it works for you?

Thanks
Elad

[trombipeti]

Hi @darkl, yep, it seems to have fixed it - now we don't have to return a dummy boolean and still get progress reporting :)

(btw, maybe I missed something, but when I tried to do dotnet add package WampSharp --version 23.5.1-develop-49 and did a build, I got the following:
"...depends on WampSharp (>= 23.5.1-develop-49) but WampSharp 23.5.1-develop-49 was not found. An approximate best match of WampSharp 23.5.1 was resolved." So I built it manually from the latest master and tried that.)

Long story short, works, thx!