Make it possible to override NUGET_PACKAGES_PATH on command line #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PackagesRoot is set to some global directory, nuget packages are installed in it and not under application-specific nuget directory, so using the default value of NUGET_PACKAGES_PATH didn't work and CMake configure step failed because it didn't find third-party packages files. Fix this by allowing to specify -DNUGET_PACKAGES_PATH=$PackagesRoot on CMake command line to override the default value.
|
Thank you for you contributions!! I merged them and will make new release asap (however, I see that the automatic version numbering is broken since I moved to CMake, so I will have to fix that first ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PackagesRoot is set to some global directory, nuget packages are installed in it and not under application-specific nuget directory, so using the default value of NUGET_PACKAGES_PATH didn't work and CMake configure step failed because it didn't find third-party packages files.
Fix this by allowing to specify -DNUGET_PACKAGES_PATH=$PackagesRoot on CMake command line to override the default value.
I've ran into this while working on my other PR and had to make this change as I couldn't build the application without it. I'm not a CMake expert (far from it), but AFAICS this shouldn't break anything and allows the build to work here.