OCPBUGS-58324: podman-etcd Add OOM score adjustment for etcd containers #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2060/1/input |
oalbrigt
reviewed
Jul 3, 2025
This change introduces a new `oom` parameter to the `podman-etcd` OCF agent. This allows tuning the Out-Of-Memory (OOM) score adjustment for the etcd container. The `oom` parameter accepts integer values from -1000 to 1000, defaulting to -997 (system-node-critical equivalent). see https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#node-out-of-memory-behavior Key changes: - Added `OCF_RESKEY_oom` parameter to agent definition (`content type="integer"`). - Integrated `--oom-score-adj` option into `podman_start()`. - Implemented input validation for `oom` in `podman_validate()`, ensuring values are within the [-1000:1000] range.
clobrano
force-pushed
the
OCPBUGS-58324-podman-etcd-oom-score-adj
branch
from
149f13a to
d08a7f7
Compare
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2060/2/input |
clobrano
changed the title
|
retest this please |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new
oomparameter to thepodman-etcdOCF agent. This allows tuning the Out-Of-Memory (OOM) score adjustment for the etcd container.The
oomparameter accepts integer values from -1000 to 1000, defaulting to -997 (system-node-critical equivalent).see https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#node-out-of-memory-behavior
Key changes:
OCF_RESKEY_oomparameter to agent definition (content type="integer").--oom-score-adjoption intopodman_start().oominpodman_validate(), ensuring values are within the [-1000:1000] range.