Dashboard addons: remove -beta from components#1700
Dashboard addons: remove -beta from components#1700HeleneAmouzou wants to merge 5 commits intomasterfrom
Conversation
BREAKING CHANGE: this component is no longer used has it has been replaced by `cc-addon-header`
BREAKING CHANGE: this component is no longer used has it has been replaced by `cc-addon-info` with `cc-addon-info.smart-jenkins`
BREAKING CHANGE: this component is no longer used has it has been replaced by `cc-addon-info` with `cc-addon-info.smart-matomo`
…new on BREAKING CHANGE: - delete old `cc-addon-credentials` - remove `-beta` from `cc-addon-credentials-beta` - adapt code
HeleneAmouzou
force-pushed
the
dashboard-addons/remove-beta
branch
from
77099cc to
7f9b57e
Compare
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/dashboard-addons/remove-beta/index.html. This preview will be deleted once this PR is closed. |
HeleneAmouzou
changed the title
HeleneAmouzou
requested review from
Galimede,
clara-layus-cc,
florian-sanders-cc,
pdesoyres-cc and
roberttran-cc
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
A small fix about translation names and small typo for this commit: feat(cc-addon-credentials)!: replace old cc-addon-credentials with new on (missing "e" at the end).
Apart from that it's a really great job @HeleneAmouzou thanks for handling that, it's really clean 👍
| @@ -219,7 +219,7 @@ export class CcAddonCredentialsContent extends LitElement { | |||
| download="${credential.value}" | |||
| ?skeleton="${skeleton}" | |||
| disable-external-link-icon | |||
| >${i18n('cc-addon-credentials-beta.download-s3cfg-file')}</cc-link | |||
| >${i18n('cc-addon-credentials.download-s3cfg-file')}</cc-link | |||
There was a problem hiding this comment.
fix: not directly related to your changes but these translations should be cc-addon-credentials-content (and there might even be .code convention for the label, I'm not sure but that's what I see from the translation file)
2 participants
Context
The new dashboard add-ons components
cc-addon-header,cc-addon-infoandcc-addon-credentials-beta, were based on already existing components.cc-addon-headeris the new version ofcc-header-addon,cc-addon-infois inspired by info components (such ascc-jenkins-info,cc-matomo-info) and thecc-addon-featurescomponent,cc-addon-credentials-betais the new version ofcc-addon-credentials.After implementing those new components, the old one are now not used anymore and can be deprecated.
What does this PR do?
Delete unused components replaced by new dashboard add-ons components :
cc-header-addon,cc-jenkins-info,cc-matomo-info,cc-addon-features.Replace old
cc-addon-credentialswith the new one.How to review?
demo-smartif everything works fine.1 or 2 reviewers should be enough.