Handle internal errors better #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we assume if we do not get a "complete" status back from the build, the build is not completed. Recently however, there have been an increase in internal TuxSuite infrastructure errors, which are not obvious upon inspection. If the build status is "error", print out the status message and exit early, as we know that the build is done since it never started :) Signed-off-by: Nathan Chancellor <[email protected]>
Internal errors (explanations of known problematic cases or an unexpected result) should be printed more clearly so that triaging can go quicker. Add a tag to print_red() and print_yellow() so that a problem matcher can print them automatically, making it clear what happened with the build. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
JustinStitt,
bwendling and
nickdesaulniers
as code owners
Member
Author
|
I am going to merge this to help with triaging but if there are any post merge comments, I am happy to address them in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual changes for the full details.