Skip to content

Conversation

@saraJimenezB
Copy link
Contributor

@saraJimenezB saraJimenezB commented Feb 3, 2025

Description

This PR aims to add support for Keycloak authentication while implementing a conditional check to differentiate between the two methods. The system should properly handle authentication based on the selected provider.
You can activate the authentication by keycloak by declaring in the .env :
AUTHENTICATION_METHOD="KEYCLOAK"

Type of change

  • New features (non-breaking change).
  • Bug fix (non-breaking change).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).

Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests if it is a core feature.
  • There is a reference to the original bug report and related work.
  • I have commented on my code, particularly in hard-to-understand areas.
  • The feature is well documented.

@taprosoft taprosoft changed the title Changes for authentication with Open ID using Keycloak fix: support authentication with Open ID using Keycloak Feb 5, 2025
@taprosoft
Copy link
Contributor

@saraJimenezB let run pre-commit install and pre-commit run --all to comfort the CI error and do the code formatting properly. Thanks.

name="google",
server_metadata_url="https://accounts.google.com/.well-known/openid-configuration",
client_id=GOOGLE_CLIENT_ID,
client_secret=GOOGLE_CLIENT_SECRET,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing

 client_kwargs={
            "scope": "openid email profile",
        },

@taprosoft
Copy link
Contributor

Close in favor of #669

@taprosoft taprosoft closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQUEST] Authentication method with Keycloak and OpenID

2 participants