-
-
Notifications
You must be signed in to change notification settings - Fork 2
Drop experimental xattr command #2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Drop experimental xattr command #2490
Conversation
The 'xattr' command has been stabilized and is now a top-level command. This commit removes the 'xattr' command from the 'experimental' subcommand. The integration tests have been updated to use the stabilized 'pna xattr' and 'pna sort' commands.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe changes remove the "experimental" subcommand designation from the xattr functionality, graduating it from experimental status to a standard CLI command. This involves removing the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
The 'xattr' and 'sort' commands have been stabilized and are now top-level commands. This commit removes the 'xattr' command from the 'experimental' subcommand and updates the integration tests to use the stabilized 'pna xattr' and 'pna sort' commands. Additionally, this commit corrects the integration tests for the 'acl', 'update', and 'stdio' commands, which were mistakenly updated. These commands are still experimental and the tests have been reverted to use the 'pna experimental' prefix.
This submission removes the experimental
xattrcommand and updates the relevant tests.PR created automatically by Jules for task 10243690787573832889 started by @ChanTsune
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.