Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Dec 18, 2025

This submission removes the experimental xattr command and updates the relevant tests.


PR created automatically by Jules for task 10243690787573832889 started by @ChanTsune

Summary by CodeRabbit

  • Changes
    • Xattr commands are now stable and no longer require the "experimental" prefix. Users can invoke xattr operations directly without the experimental subcommand token.

✏️ Tip: You can customize this high-level summary in your review settings.

The 'xattr' command has been stabilized and is now a top-level command.
This commit removes the 'xattr' command from the 'experimental' subcommand.
The integration tests have been updated to use the stabilized 'pna xattr' and 'pna sort' commands.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes remove the "experimental" subcommand designation from the xattr functionality, graduating it from experimental status to a standard CLI command. This involves removing the Xattr variant from the ExperimentalCommands enum and updating all related test invocations to call xattr commands without the "experimental" prefix.

Changes

Cohort / File(s) Summary
Command dispatch removal
cli/src/command/experimental.rs
Removed Xattr(command::xattr::XattrCommand) variant from ExperimentalCommands enum and removed corresponding match arm in Command::execute
Test updates
cli/tests/cli/xattr/dump.rs, cli/tests/cli/xattr/get.rs, cli/tests/cli/xattr/missing_file.rs, cli/tests/cli/xattr/remove.rs, cli/tests/cli/xattr/restore.rs, cli/tests/cli/xattr/set.rs, cli/tests/cli/xattr/set_and_remove.rs, cli/tests/cli/xattr/set_base64.rs, cli/tests/cli/xattr/set_hex.rs, cli/tests/cli/xattr/set_overwrite.rs
Removed "experimental" argument from CLI invocations, allowing xattr commands to be called directly without the experimental prefix

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are homogeneous and follow a consistent pattern across all test files
  • Single enum variant removal with corresponding match arm deletion
  • Straightforward argument removal with no logic changes

Suggested labels

cli

Poem

🐰 The xattr hops free from its experimental pen,
No longer "experimental" prefixed, time and again!
From unstable grounds it now stands tall and true,
A feature full-fledged—our fuzzy CLI crew!
hops rejoicefully

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: removing the experimental xattr command from the codebase.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChanTsune
Copy link
Owner

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

The 'xattr' and 'sort' commands have been stabilized and are now top-level commands. This commit removes the 'xattr' command from the 'experimental' subcommand and updates the integration tests to use the stabilized 'pna xattr' and 'pna sort' commands.

Additionally, this commit corrects the integration tests for the 'acl', 'update', and 'stdio' commands, which were mistakenly updated. These commands are still experimental and the tests have been reverted to use the 'pna experimental' prefix.
@github-actions github-actions bot added the cli This issue is about cli application label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli This issue is about cli application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants