Update Notification Refactor to Phase 1 #11167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opes (CenterForOpenScience#11126) ## Purpose Allow more scopes for application write PAT, but remove it from admin scope. ## Changes - changes scope composition to add write_application to `FULL_WRITE` - adds tests `test_application_detail_scopes.py` - improves `test_application_detail.py` and fixes url validation issues. ## Side Effects Fixing the some of the Application Detail view tests (spliting them up into more atomic tests in the process), relvealed a additional issue with application attribute url length maxuims being poorly validated. This comment explain more: https://github.com/CenterForOpenScience/osf.io/pull/11126/files#r2074027385 ## Ticket https://openscience.atlassian.net/browse/ENG-7921
## Purpose Revert async function that causes 502
(cherry picked from commit 9485c8b)
…ce/feature/pbs-25-09 Feature/pbs 25 09
PB&S 25-09
…registrations remain private (CenterForOpenScience#11125) ## Purpose fix was_public state when flag spam ## Changes - correct check if node was public when flag_spam - use earliest confirm/flag spam log to check if node was public instead of the latest one --- - fix TypeError when check archiving status for stuck registrations (not related to ticket ENG-7873, but it's just one line `permissible_addons = set(permissible_addons)`, so no additional testing is required) ## QA Notes I couldn't reproduce this issue via UI, but combination `confirm_spam()` -> `flag_spam()` -> `...` breaks this feature. I'm not sure if it's exactly what's happening in our case, but since `flag_spam()` is used with automatic spam checks during node/preprint updates, it's quite possible. ## Ticket https://openscience.atlassian.net/browse/ENG-7873
…ence#11137) ## Purpose Embargo termination logging doesn't provide useful info regarding of what error was raised ## Changes Improved logging, removed if statement duplicate ## Ticket https://openscience.atlassian.net/browse/ENG-7927
## Purpose allow admins change registration providers ## Changes - add a dropdown menu to provider section on admin UI - add endpoint that allows to update registration provider ## Ticket https://openscience.atlassian.net/browse/ENG-7977
## Purpose support related_counts for view_only_links ## Ticket https://openscience.atlassian.net/browse/ENG-8051
…on subscription field (CenterForOpenScience#11150)
…ience#11139) ## Purpose Update the alternate email confirmation system to v2 ## Changes - adds `/users/<user_id>/confirm/` route with views - adds tests - adds `/users/<user_id>/sanction_response/` route with views - adds tests - cleans-up and simplifies sanction_handler code to work better in different request contexts ## Ticket https://openscience.atlassian.net/browse/ENG-7965
…onfirm-user Fix issue where not having any external identities caused a 500
…ience#11140) ## Purpose adds new relationship for collections a node is in. ## Changes - splits up node detail tests into more workable files <500 that are more atomic - add related view for collection to nodes detail - adds tests ## Ticket https://openscience.atlassian.net/browse/ENG-7966
…ForOpenScience#11158) ## Purpose - Add ArtifactOutcome attributes to linked registrations ## Changes - add annotations to linked registration views - add test cases - split up tests to keep < 500 ln, clean them up and make more atomic ## Ticket https://openscience.atlassian.net/browse/ENG-8148
…ght exception (CenterForOpenScience#11161) ## Purpose If user email already existed the error was uncaught. ## Changes - adds change to catch 400 error - adds test case.
…OpenScience/osf.io into feature/notification-refactor-phase-1 * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # api_tests/nodes/views/test_node_detail.py # api_tests/nodes/views/test_node_linked_registrations.py # framework/auth/oauth_scopes.py # tests/test_registrations/test_retractions.py
…hub.com/bodintsov/osf.io into feature/notification-refactor-phase-1 * 'feature/remove-remaining-quickiles-code' of https://github.com/bodintsov/osf.io: flake8 fixed tests remove quickfiles
Johnetordoff
force-pushed
the
feature/notification-refactor-phase-1
branch
from
05d1263 to
1a2f7c1
Compare
…ap-Zherebetskyi/osf.io into feature/notification-refactor-phase-1 * 'feature/remove_test_speed-up' of https://github.com/Ostap-Zherebetskyi/osf.io: update mails mock Update send_mail mocks
Johnetordoff
force-pushed
the
feature/notification-refactor-phase-1
branch
from
9fa911c to
013d422
Compare
Johnetordoff
merged commit f7f8197
into
CenterForOpenScience:refactor-notifications
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket