fix: 🐛 add day and night background selectors #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is necessary - the dynamic background selector (based on style and based on time of the day) is enough, and is also what Fedora does. The problem is that /org/gnome/desktop/background/picture-uri-dark is somehow not overridden correctly on CentOS and is still showing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to make static selections of light or dark backgrounds in different styles selections (e.g., it was not possible to load light background in dark mode and vice-versa). This PR adds static selectors for light and dark backgrounds so you can select different backgrounds no matter the what style selection is active.
Here is a graphical representation, you could use to validate the background selectors: