Skip to content

Conversation

jasonlizhengjian
Copy link
Contributor

Adds a new CLI flag that enables JSON response formatting:

  • Adds json_response field to RequestFuncInput model
  • Modifies OpenAI backend to apply JSON formatting when flag is enabled
  • Includes response_format and chat_template_kwargs settings
  • Prompts model to avoid premature JSON closure

Adds a new CLI flag that enables JSON response formatting:
- Adds json_response field to RequestFuncInput model
- Modifies OpenAI backend to apply JSON formatting when flag is enabled
- Includes response_format and chat_template_kwargs settings
- Prompts model to avoid premature JSON closure
Copy link
Contributor

@benchislett benchislett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update the README with the new flags

@vadiklyutiy
Copy link
Contributor

@jasonlizhengjian
Just interested in how this PR is going? Wish to gave control over json mode and disable thinking via options. It'd be more convenient

@jasonlizhengjian jasonlizhengjian marked this pull request as ready for review July 28, 2025 19:51
@jasonlizhengjian
Copy link
Contributor Author

jasonlizhengjian commented Jul 28, 2025

@jasonlizhengjian Just interested in how this PR is going? Wish to gave control over json mode and disable thinking via options. It'd be more convenient

@vadiklyutiy It's ready for review

@vadiklyutiy
Copy link
Contributor

@jasonlizhengjian Just interested in how this PR is going? Wish to gave control over json mode and disable thinking via options. It'd be more convenient

@vadiklyutiy It's ready for review

Ben asked some changes above

@jasonlizhengjian
Copy link
Contributor Author

requested changes have already been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants