[PATCH] Fix otel requests #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that even if the flag OTEL_ENABLED is disabled, when you call tracer.start_as_current_span directly, it looks like otel gets enable with default params and tries to send the content to
host='localhost', port=4318
.To fix this, I used nullcontext in case the flag is not enable and so we can avoid this error.
I tested on dlcluster and it works.