Skip to content

No cover some stuff #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

johnzhou721
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jul 30, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/qasync
  __init__.py
  _common.py
  _windows.py
Project Total  

This report was generated by python-coverage-comment-action

@hosaka
Copy link
Collaborator

hosaka commented Jul 31, 2025

After looking at this up close, we loose all the static typing by doing getattr and import_module. For example my LSP (pyright with ruff) can figure out that I have a Qt library available in my venv, thus one of the imports is not marked as an error and I get types and autocomplete for free. Which is not the case when using the changes proposed here.

While verbose, it helps to have the typing info while working with the code. I would like to move towards adding typing as suggested in #124.

@johnzhou721 johnzhou721 changed the title Get rid of branching in top of dunder init and no cover some stuff No cover some stuff Jul 31, 2025
@johnzhou721 johnzhou721 marked this pull request as ready for review August 1, 2025 00:54
@johnzhou721
Copy link
Contributor Author

@hosaka Could you please take another look at this? Thanks!

@hosaka
Copy link
Collaborator

hosaka commented Aug 25, 2025

@johnzhou721 Sorry I've neglected this for a bit. I think this doesn't add much value to be frank. The env_to_mod_map is being covered now with the coverage aggregated across all test variations since 57a7e2a

I feel at this point that peppering more "no cover" is not of much use. I am going to close this for now, if you you'd like to improve the test coverage and have spare time, feel free to PR changes that address this.

@hosaka hosaka closed this Aug 25, 2025
@johnzhou721
Copy link
Contributor Author

johnzhou721 commented Aug 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants