Skip to content

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jul 8, 2025

No tests added. Currently these ops aren't implemented for emulators so it's only possible to test on actual devices. I submitted a job using RNG to H1-1 using process_circuit(); this passed compilation and is in the queue.

CI failure is unrelated.

@cqc-alec cqc-alec changed the title Ae/rng Update list of op types for validity check; update version and changelog for 0.51.0 release Jul 8, 2025
@cqc-alec cqc-alec requested a review from cqc-melf July 8, 2025 08:24
@cqc-alec cqc-alec marked this pull request as ready for review July 8, 2025 08:24
@cqc-alec cqc-alec requested a review from yao-cqc as a code owner July 8, 2025 08:24
Copy link
Collaborator

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding this only works for submission via qasm, but QIR is the default? Should we check that at some point that this requires qasm submission?

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented Jul 8, 2025

From my understanding this only works for submission via qasm, but QIR is the default? Should we check that at some point that this requires qasm submission?

When submitting the same job without specifying QASM we get the error Bad operation type: RNGNum from pytket-qir. Do you want to add a test for this?

@cqc-melf
Copy link
Collaborator

cqc-melf commented Jul 8, 2025

From my understanding this only works for submission via qasm, but QIR is the default? Should we check that at some point that this requires qasm submission?

When submitting the same job without specifying QASM we get the error Bad operation type: RNGNum from pytket-qir. Do you want to add a test for this?

I was more thinking about having a check before the conversion that we do some type of predicate? But not sure if that is to much effort?

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented Jul 8, 2025

From my understanding this only works for submission via qasm, but QIR is the default? Should we check that at some point that this requires qasm submission?

When submitting the same job without specifying QASM we get the error Bad operation type: RNGNum from pytket-qir. Do you want to add a test for this?

I was more thinking about having a check before the conversion that we do some type of predicate? But not sure if that is to much effort?

I think probably not worth it as this is a fairly niche feature and the error message from pytket-qir is reasonably informative.

@cqc-melf cqc-melf self-requested a review July 8, 2025 09:33
@cqc-alec cqc-alec merged commit c58fad3 into main Jul 8, 2025
8 of 9 checks passed
@cqc-alec cqc-alec deleted the ae/rng branch July 8, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants