Skip to content

feat(hugr-py): Add StaticArray to standard extensions #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

mark-koch
Copy link
Contributor

Closes #1984

@mark-koch mark-koch requested a review from a team as a code owner March 17, 2025 11:14
@mark-koch mark-koch requested a review from ss2165 March 17, 2025 11:14
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.65%. Comparing base (6a625d1) to head (8111ab1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
hugr-py/src/hugr/std/collections/static_array.py 88.57% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   83.64%   83.65%           
=======================================
  Files         208      209    +1     
  Lines       38958    38993   +35     
  Branches    35666    35666           
=======================================
+ Hits        32588    32620   +32     
- Misses       4530     4533    +3     
  Partials     1840     1840           
Flag Coverage Δ
python 91.82% <88.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


@property
def ty(self) -> tys.Type:
assert isinstance(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that it's copyable too?

@mark-koch mark-koch enabled auto-merge March 17, 2025 13:47
@mark-koch mark-koch disabled auto-merge March 17, 2025 13:47
@mark-koch mark-koch added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit cf860f3 Mar 17, 2025
23 checks passed
@mark-koch mark-koch deleted the mk/static-array-py branch March 17, 2025 14:27
github-merge-queue bot pushed a commit that referenced this pull request Mar 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.11.2](hugr-py-v0.11.1...hugr-py-v0.11.2)
(2025-03-21)


### Features

* add exit operation to prelude
([#2008](#2008))
([6bd7665](6bd7665))
* Add llvm codegen for collections.static_array
([#2003](#2003))
([f3dd145](f3dd145))
* **hugr-py:** Add `StaticArray` to standard extensions
([#1985](#1985))
([cf860f3](cf860f3)),
closes [#1984](#1984)
* **hugr-py:** Support envelope compression
([#1994](#1994))
([434c563](434c563))


### Bug Fixes

* StaticArrayValue serialisation
([#2009](#2009))
([3fe6bf8](3fe6bf8))


### Reverts

* Revert breaking change to StaticArrayValue
([33a2b49](33a2b49))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: hugrbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hugr-py: Add StaticArray
2 participants